Skip to content

Comments

Fix shared backend tests that don't work with NEXT_PUBLIC_ENABLE_SUOMIFI=1#3782

Merged
karisal-anders merged 1 commit intomainfrom
fix-shared-tests
Oct 16, 2025
Merged

Fix shared backend tests that don't work with NEXT_PUBLIC_ENABLE_SUOMIFI=1#3782
karisal-anders merged 1 commit intomainfrom
fix-shared-tests

Conversation

@karisal-anders
Copy link
Collaborator

@karisal-anders karisal-anders commented Oct 16, 2025

Description ✨

Fix shared backend tests that don't work with NEXT_PUBLIC_ENABLE_SUOMIFI=1

Still one test remains that does not work if
NEXT_PUBLIC_ENABLE_SUOMIFI=1 when bringing up the backend.
Add FIXME to that test case.

You can try running the shared backend tests before this
commit to see that they do not all pass if you have
NEXT_PUBLIC_ENABLE_SUOMIFI=1, e.g. using Kesäseteli's
backend (You can use Benefit's too if you like):

docker exec -it kesaseteli-backend bash
pytest . -vv --pyargs shared --ignore-glob="**"

Still one test remains that does not work if
NEXT_PUBLIC_ENABLE_SUOMIFI=1 when bringing up the backend. Add FIXME to
that test case.

You can try running the shared backend tests before this commit to see
that they do not all pass if you have NEXT_PUBLIC_ENABLE_SUOMIFI=1, e.g.
using Kesäseteli's backend (You can use Benefit's too if you like):
```
docker exec -it kesaseteli-backend bash
pytest . -vv --pyargs shared --ignore-glob="**"
```
@karisal-anders karisal-anders requested review from a team as code owners October 16, 2025 09:21
@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@terovirtanen
Copy link
Contributor

YJDH-KESASETELI-API branch is deployed to platta: https://yjdh-kesaseteli-pr3782.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://nuortenkesaseteli-pr3782.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://kesaseteli-handler-ui-pr3782.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-pr3782.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-handler-ui-pr3782.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://nuortenkesaseteli-pr3782.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-pr3782.dev.hel.ninja 😆🎉🎉🎉

@karisal-anders karisal-anders removed the request for review from a team October 16, 2025 10:06
@karisal-anders
Copy link
Collaborator Author

The problems with Helsinkilisa-review have no discernible way to be caused by this PR's changes, as these changes are only to shared backend test files and only adding env variable overrides to @override_settings calls in them (+one comment).

@karisal-anders karisal-anders merged commit 2516d50 into main Oct 16, 2025
122 of 125 checks passed
@karisal-anders karisal-anders deleted the fix-shared-tests branch October 16, 2025 10:12
@karisal-anders
Copy link
Collaborator Author

karisal-anders commented Oct 16, 2025

@voneiden FYI there are problems with installing dependencies with Benefit (see also previous comment), see the details of failures in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants